fix(amazonq): codefix does not do error handling #6307
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashishrp-aws
reviewed
Jan 6, 2025
| issue: targetIssue, | ||
| isGenerateFixLoading: false, | ||
| isGenerateFixError: true, | ||
| generateFixError: getErrorMsg(err as AWSError, true), |
Contributor
There was a problem hiding this comment.
@ctlai95 can we use user friendly error messages instead passing the service error straight to user? Like how we handle code review errors.
ashishrp-aws
approved these changes
Jan 7, 2025
| issue: targetIssue, | ||
| isGenerateFixLoading: false, | ||
| isGenerateFixError: true, | ||
| generateFixError: getErrorMsg(err as AWSError, true), |
Contributor
There was a problem hiding this comment.
Look to add in the following before to avoid needing to cast:
if (!(err instanceof Error)) {
throw new Error('Unexpected non error', err) // modify this as needed
}
Contributor
There was a problem hiding this comment.
using isAwsError may be better:
| filePath?: string | ||
| isGenerateFixLoading?: boolean | ||
| isGenerateFixError?: boolean | ||
| generateFixError?: string | null |
Contributor
There was a problem hiding this comment.
I think this should be good enough
Suggested change
| generateFixError?: string | null | |
| generateFixError?: string |
Contributor
Author
There was a problem hiding this comment.
I think null is required for this since I want to maintain this behavior where the following will remove the error from the webview:
updateSecurityIssueWebview({
...
generateFixError: null
})while the absence of the field should not remove it
updateSecurityIssueWebview({
...
issue: newIssue
})| public setIsGenerateFixError(isGenerateFixError: boolean) { | ||
| this.isGenerateFixError = isGenerateFixError | ||
| this.onChangeGenerateFixError.fire(isGenerateFixError) | ||
| public setGenerateFixError(generateFixError: string | null | undefined) { |
Contributor
There was a problem hiding this comment.
Can probably drop null
| relativePath: '', | ||
| isGenerateFixLoading: false, | ||
| isGenerateFixError: false, | ||
| generateFixError: undefined as string | null | undefined, |
Contributor
There was a problem hiding this comment.
This should be good enough. I think the types upstream may need to be modified
Suggested change
| generateFixError: undefined as string | null | undefined, | |
| generateFixError: undefined |
| private filePath: string | undefined | ||
| private isGenerateFixLoading: boolean = false | ||
| private isGenerateFixError: boolean = false | ||
| private generateFixError: string | null | undefined = undefined |
Contributor
There was a problem hiding this comment.
Try
Suggested change
| private generateFixError: string | null | undefined = undefined | |
| private generateFixError: string | undefined = undefined |
nkomonen-amazon
approved these changes
Jan 17, 2025
karanA-aws
pushed a commit
to karanA-aws/aws-toolkit-vscode
that referenced
this pull request
Jan 17, 2025
## Problem Code fix errors are not handled correctly, only shows a generic error notification and webview is not updated. ## Solution Surface the server error to the UI <img width="658" alt="image" src="https://github.com/user-attachments/assets/6e0e72d1-7de1-415d-a4d4-891d94e6d7ea" /> --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license.
kevluu-aws
pushed a commit
to kevluu-aws/aws-toolkit-vscode
that referenced
this pull request
Jan 23, 2025
## Problem Code fix errors are not handled correctly, only shows a generic error notification and webview is not updated. ## Solution Surface the server error to the UI <img width="658" alt="image" src="https://github.com/user-attachments/assets/6e0e72d1-7de1-415d-a4d4-891d94e6d7ea" /> --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license.
chungjac
pushed a commit
to chungjac/aws-toolkit-vscode
that referenced
this pull request
Jan 24, 2025
## Problem Code fix errors are not handled correctly, only shows a generic error notification and webview is not updated. ## Solution Surface the server error to the UI <img width="658" alt="image" src="https://github.com/user-attachments/assets/6e0e72d1-7de1-415d-a4d4-891d94e6d7ea" /> --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license.
s7ab059789
pushed a commit
to s7ab059789/aws-toolkit-vscode
that referenced
this pull request
Feb 19, 2025
## Problem Code fix errors are not handled correctly, only shows a generic error notification and webview is not updated. ## Solution Surface the server error to the UI <img width="658" alt="image" src="https://github.com/user-attachments/assets/6e0e72d1-7de1-415d-a4d4-891d94e6d7ea" /> --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Code fix errors are not handled correctly, only shows a generic error notification and webview is not updated.
Solution
Surface the server error to the UI
feature/xbranches will not be squash-merged at release time.