fix(amazonq): Skip including deleted files for FeatureDev context. #6312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ctidd
approved these changes
Jan 6, 2025
neilk-aws
force-pushed
the
neilk-aws/fix-prepare-context
branch
from
216dd73 to
20d19cd
Compare
Hweinstock
reviewed
Jan 7, 2025
Hweinstock
reviewed
Jan 7, 2025
Contributor
|
Is there a way we can test this behavior? Something along the lines of having |
neilk-aws
force-pushed
the
neilk-aws/fix-prepare-context
branch
from
20d19cd to
d8aff5e
Compare
justinmk3
reviewed
Jan 7, 2025
justinmk3
reviewed
Jan 7, 2025
| } catch (error) { | ||
| if (error instanceof Error && error.message.includes('File not found')) { | ||
| // No-op: Skip if file was deleted or does not exist | ||
| // Reference: https://github.com/cthackers/adm-zip/blob/1cd32f7e0ad3c540142a76609bb538a5cda2292f/adm-zip.js#L296-L321 |
Contributor
There was a problem hiding this comment.
does it set a code ? try hasCode
Contributor
Author
There was a problem hiding this comment.
This error does not set a code: https://github.com/cthackers/adm-zip/blob/1cd32f7e0ad3c540142a76609bb538a5cda2292f/util/errors.js#L56
neilk-aws
force-pushed
the
neilk-aws/fix-prepare-context
branch
from
d8aff5e to
d12d1d6
Compare
Contributor
Author
This is mitigating a situation where there is a race condition and the file is deleted as they are being zipped. In this case, |
justinmk3
approved these changes
Jan 7, 2025
karanA-aws
pushed a commit
to karanA-aws/aws-toolkit-vscode
that referenced
this pull request
Jan 17, 2025
…#6312 ## Problem When zipping context for /dev, customer build processes (file watchers, etc.) may delete build artifacts we’ve already enumerated but have not added to the archive. As a best practice, customers should `.gitignore` these types of files, but in the event they don't, this has the potential to block /dev from running. ## Solution Skip affected files, which are not found when adding to zip context for Feature Dev.
s7ab059789
pushed a commit
to s7ab059789/aws-toolkit-vscode
that referenced
this pull request
Feb 19, 2025
…#6312 ## Problem When zipping context for /dev, customer build processes (file watchers, etc.) may delete build artifacts we’ve already enumerated but have not added to the archive. As a best practice, customers should `.gitignore` these types of files, but in the event they don't, this has the potential to block /dev from running. ## Solution Skip affected files, which are not found when adding to zip context for Feature Dev.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When zipping context for /dev, customer build processes (file watchers, etc.) may delete build artifacts we’ve already enumerated but have not added to the archive. As a best practice, customers should
.gitignorethese types of files, but in the event they don't, this has the potential to block /dev from running.Solution
Skip affected files, which are not found when adding to zip context for Feature Dev.
feature/xbranches will not be squash-merged at release time.