-
Notifications
You must be signed in to change notification settings - Fork 751
fix(amazonq): Prevent customization override if user has manually selected a customization #6316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
4f1d757 to
318f09c
Compare
| name: 'testCustomizationName', | ||
| description: 'testCustomizationDescription', | ||
| } | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i feel it's better to have sinon.stub(FeatureConfigProvider, 'getFeature').returns(featureCustomization) here as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to simulate the real case when there is an override and user pre-selected customization
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added to beforeEach so it's present for all tests
|
thanks for adding test coverage |
318f09c to
138fc93
Compare
|
Is there a more concise way to describe this change in the PR title? from lint-commits: |
| @@ -0,0 +1,4 @@ | |||
| { | |||
| "type": "Bug Fix", | |||
| "description": "Change logic for customization override to not override if user has manually selected a customization" | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "description": "Change logic for customization override to not override if user has manually selected a customization" | |
| "description": "User-selected customizations are sometimes not being persisted." |
or similar, see https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#changelog
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
138fc93 to
a1a4c1c
Compare
a1a4c1c to
409d575
Compare
409d575 to
a211ce6
Compare
a211ce6 to
78ece02
Compare
…anually selected a customization
78ece02 to
ec9803f
Compare
|
Lots of connection resets in the test runs today, will try another push to see if we can get them running again but they are passing locally and passed previously. |
|
/retryBuilds |
Problem
If a user was part of an AB group with a customization override, they could only ever use the customization from the override regardless of personal choice.
Solution
Changes the logic for when a customization will be overridden if the user is part of an AB group that has a customization override. With this change, if the user has manually selected a customization, it will not be overridden by the AB customization.
feature/xbranches will not be squash-merged at release time.