Skip to content

fix(amazonq): fix for /test for files outside of workspace. #6321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ashishrp-aws merged 5 commits into from
Jan 8, 2025
Merged

fix(amazonq): fix for /test for files outside of workspace. #6321

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
76027b6
fix for /test for files outside of workspace.
ashishrp-aws Jan 8, 2025
eb7ed3e
Added changelog
ashishrp-aws Jan 8, 2025
64a9589
Update controller.ts
ashishrp-aws Jan 8, 2025
0b4dc1a
Update packages/core/src/amazonqTest/chat/controller/controller.ts
ashishrp-aws Jan 8, 2025
d9f7093
Fix in chat message
ashishrp-aws Jan 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/amazonq/.changes/next-release/Bug Fix-b071ef14-0566-4efa-9a16-43362b87639f.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
{
"type": "Bug Fix",
"description": "Amazon Q /test: Fix to redirect /test to generate tests in chat for external files out of workspace scope."
}
17 changes: 11 additions & 6 deletions packages/core/src/amazonqTest/chat/controller/controller.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -439,16 +439,21 @@ export class TestController {

const language = await this.getLanguageForFilePath(filePath)
session.fileLanguage = language
const workspaceFolder = vscode.workspace.getWorkspaceFolder(fileEditorToTest.document.uri)

/*
For Re:Invent 2024 we are supporting only java and python for unit test generation, rest of the languages shows the similar experience as CWC
*/
if (language !== 'java' && language !== 'python') {
const unsupportedLanguage = language.charAt(0).toUpperCase() + language.slice(1)
let unsupportedMessage = `<span style="color: #EE9D28;">&#9888;<b>I'm sorry, but /test only supports Python and Java</b><br></span> While ${unsupportedLanguage} is not supported, I will generate a suggestion below. `
// handle the case when language is undefined
if (!unsupportedLanguage) {
unsupportedMessage = `<span style="color: #EE9D28;">&#9888;<b>I'm sorry, but /test only supports Python and Java</b><br></span> I will still generate a suggestion below. `
if (!['java', 'python'].includes(language) || workspaceFolder === undefined) {
let unsupportedMessage: string
const unsupportedLanguage = language ? language.charAt(0).toUpperCase() + language.slice(1) : ''
if (!workspaceFolder) {
// File is outside of workspace
unsupportedMessage = `<span style="color: #EE9D28;">&#9888;<b>I can't generate tests for ${fileName}</b> because the file is outside of workspace scope.<br></span> I can still provide examples, instructions and code suggestions.`
} else if (unsupportedLanguage) {
unsupportedMessage = `<span style="color: #EE9D28;">&#9888;<b>I'm sorry, but /test only supports Python and Java</b><br></span> While ${unsupportedLanguage} is not supported, I will generate a suggestion below.`
} else {
unsupportedMessage = `<span style="color: #EE9D28;">&#9888;<b>I'm sorry, but /test only supports Python and Java</b><br></span> I will still generate a suggestion below.`
}
this.messenger.sendMessage(unsupportedMessage, tabID, 'answer')
await this.onCodeGeneration(session, message.prompt, tabID, fileName, filePath)
Expand Down
Loading