Skip to content

Conversation

@jpinkney-aws
Copy link
Contributor

Problem

The language server initialization logic incorrectly handles custom server paths. When users specify a custom language server location through an environment variable, the code still appends servers/aws-lsp-codewhisperer.js to the path, leading to incorrect server resolution.

Solution

When a custom language server path is provided via environment variable (indicated by location === 'override'), use the specified asset directory path directly instead of appending the default server path. This allows users to have full control over the language server location.


  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jpinkney-aws jpinkney-aws requested a review from a team as a code owner January 10, 2025 15:11
@github-actions
Copy link

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.
  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@jpinkney-aws jpinkney-aws changed the title fix(amazonq): Overrides should reference assets directly fix(amazonq): Language server overrides should reference assets directly Jan 10, 2025
@jpinkney-aws jpinkney-aws merged commit f4f022f into aws:feature/amazonqLSP Jan 10, 2025
13 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants