deps(clients): regen qdev streaming client (IGNORE) #6335
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hweinstock
force-pushed
the
regenClients
branch
3 times, most recently
from
afbd917 to
1bb2f6f
Compare
| return { | ||
| apiVersion: "2024-06-11", | ||
| base64Decoder: config?.base64Decoder ?? fromBase64, | ||
| export const getRuntimeConfig = (config: QDeveloperStreamingClientConfig) => ({ |
Contributor
There was a problem hiding this comment.
Maybe this needs to be explicitly typed, based on this LLM comment:
If you're exporting the function in runtimeConfig.shared.ts, add a return type there:
In runtimeConfig.shared.ts:
import { RuntimeConfig } from "@aws-sdk/types";
export const getRuntimeConfig = (): RuntimeConfig => {
// Your implementation here
};
Contributor
Author
There was a problem hiding this comment.
I don't think @aws-sdk/types exports this type for us unfortunately. Also, hoping to avoid manually adjusting generated code. One of the goals is to have these clients be generated as a build step or at least in an easily automatable fashion, so any manual touching of the generated files will be overwritten.
Hweinstock
changed the title
Contributor
Author
|
Moved to #6439 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Build instructions are outdated and don't appear to work. This PR is an attempt to update them and regenerate the clients.
Solution
Notes
@smithy/*packages directly and prefer@aws-sdk/*.--
feature/xbranches will not be squash-merged at release time.