From b66b01a932a2a5b5d4551105b9c09bab91bc0d3c Mon Sep 17 00:00:00 2001 From: Jacob Chung Date: Mon, 13 Jan 2025 15:40:51 -0800 Subject: [PATCH 1/2] add message after accept/reject action --- .../Bug Fix-b6d52b75-69e6-47bb-939b-5ddede03f977.json | 4 ++++ packages/core/src/amazonqTest/chat/controller/controller.ts | 5 +++++ 2 files changed, 9 insertions(+) create mode 100644 packages/amazonq/.changes/next-release/Bug Fix-b6d52b75-69e6-47bb-939b-5ddede03f977.json diff --git a/packages/amazonq/.changes/next-release/Bug Fix-b6d52b75-69e6-47bb-939b-5ddede03f977.json b/packages/amazonq/.changes/next-release/Bug Fix-b6d52b75-69e6-47bb-939b-5ddede03f977.json new file mode 100644 index 00000000000..8772b9bf10d --- /dev/null +++ b/packages/amazonq/.changes/next-release/Bug Fix-b6d52b75-69e6-47bb-939b-5ddede03f977.json @@ -0,0 +1,4 @@ +{ + "type": "Bug Fix", + "description": "Amazon Q /test: Unit test generation completed message shows after accept/reject action" +} diff --git a/packages/core/src/amazonqTest/chat/controller/controller.ts b/packages/core/src/amazonqTest/chat/controller/controller.ts index 35e234cc01a..9e6dcfaff0b 100644 --- a/packages/core/src/amazonqTest/chat/controller/controller.ts +++ b/packages/core/src/amazonqTest/chat/controller/controller.ts @@ -717,6 +717,9 @@ export class TestController { await vscode.window.showTextDocument(document) // TODO: send the message once again once build is enabled // this.messenger.sendMessage('Accepted', message.tabID, 'prompt') + + this.messenger.sendMessage('Unit test generation completed', message.tabID, 'answer') + telemetry.ui_click.emit({ elementId: 'unitTestGeneration_acceptDiff' }) TelemetryHelper.instance.sendTestGenerationToolkitEvent( @@ -840,6 +843,8 @@ export class TestController { private async endSession(data: any, step: FollowUpTypes) { const session = this.sessionStorage.getSession() if (step === FollowUpTypes.RejectCode) { + this.messenger.sendMessage('Unit test generation completed.', data.tabID, 'answer') + TelemetryHelper.instance.sendTestGenerationToolkitEvent( session, true, From e5d4538b4d98152f5291d1cb2136abd6e4a33a03 Mon Sep 17 00:00:00 2001 From: Jacob Chung Date: Tue, 14 Jan 2025 14:33:35 -0800 Subject: [PATCH 2/2] message now only in endSession --- .../core/src/amazonqTest/chat/controller/controller.ts | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/packages/core/src/amazonqTest/chat/controller/controller.ts b/packages/core/src/amazonqTest/chat/controller/controller.ts index 9e6dcfaff0b..57d4d231d07 100644 --- a/packages/core/src/amazonqTest/chat/controller/controller.ts +++ b/packages/core/src/amazonqTest/chat/controller/controller.ts @@ -717,9 +717,6 @@ export class TestController { await vscode.window.showTextDocument(document) // TODO: send the message once again once build is enabled // this.messenger.sendMessage('Accepted', message.tabID, 'prompt') - - this.messenger.sendMessage('Unit test generation completed', message.tabID, 'answer') - telemetry.ui_click.emit({ elementId: 'unitTestGeneration_acceptDiff' }) TelemetryHelper.instance.sendTestGenerationToolkitEvent( @@ -841,10 +838,10 @@ export class TestController { // TODO: Check if there are more cases to endSession if yes create a enum or type for step private async endSession(data: any, step: FollowUpTypes) { + this.messenger.sendMessage('Unit test generation completed.', data.tabID, 'answer') + const session = this.sessionStorage.getSession() if (step === FollowUpTypes.RejectCode) { - this.messenger.sendMessage('Unit test generation completed.', data.tabID, 'answer') - TelemetryHelper.instance.sendTestGenerationToolkitEvent( session, true,