From ffd27c60361c755e67ed7319037130bc45edc4ae Mon Sep 17 00:00:00 2001 From: Josh Pinkney Date: Mon, 20 Jan 2025 09:57:44 -0500 Subject: [PATCH] ci(core): Request should not throw on 304 status --- packages/core/src/shared/request.ts | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/packages/core/src/shared/request.ts b/packages/core/src/shared/request.ts index 9f3bf50047f..827e3e3e445 100644 --- a/packages/core/src/shared/request.ts +++ b/packages/core/src/shared/request.ts @@ -99,7 +99,11 @@ class FetchRequest { } async #throwIfBadResponse(request: RequestParams, response: Response, url: string) { - if (response.ok) { + /** + * response.ok only returns true for 200-299. + * We need to explicitly allow 304 since it means the cached version is still valid + */ + if (response.ok || response.status === 304) { return }