fix(amazonq): Adding target source file to the zip before traversing the repository #6618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ctlai95
changed the title
ctlai95
reviewed
Feb 19, 2025
Comment on lines
+367
to
+383
| const relativePath = getWorkspaceRelativePath(filePath, { workspaceFolders }) | ||
|
|
||
| if (relativePath) { | ||
| const fileStat = await fs.stat(targetUri) | ||
|
|
||
| const fileContent = await readFile(targetUri) | ||
| if (fileContent !== undefined) { | ||
| totalSizeBytes += fileStat.size | ||
| storage.push({ | ||
| workspaceFolder: relativePath.workspaceFolder, | ||
| relativeFilePath: relativePath.relativePath, | ||
| fileUri: targetUri, | ||
| fileContent: fileContent, | ||
| zipFilePath: prefixWithFolderPrefix(relativePath.workspaceFolder, relativePath.relativePath), | ||
| }) | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
nit: can probably simplify this since you do the same thing in lines 402-429
Contributor
There was a problem hiding this comment.
Yes, please de-dup this code
ctlai95
approved these changes
Feb 19, 2025
ashishrp-aws
approved these changes
Feb 19, 2025
auto-merge was automatically disabled
February 19, 2025 21:19
Pull request was closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
/test, sometimes target source file is not being collected as part of zip and this is causing the backend to fail.Solution
feature/xbranches will not be squash-merged at release time.