Skip to content

Conversation

@witness-me
Copy link
Contributor

@witness-me witness-me commented Feb 24, 2025

Problem

  1. In case we introduce new feature dependant on the Toolkit change in the future, users may face issues if they don't update their toolkit right away (as their toolkit version won't have the new functionality in place)
  2. There was a regression from my previous PR, in package.json - most possibly due to incorrect merge conflict resolution (since the original file has been moved to another folder). The regression is that undo command override is not working, causing uncorrect undo command behaviour when triggered from webview
  3. There is some redundant code which is not useful and causes incorrect behaviour, showing in the webview view screen

Solution

  1. To ensure compatibility, we are adding an unsupported message handler in advance. In case of unsupported message it will send an appropriate response back to the webview, so we will be able to use it to handle the error gracefully on the webview side
  2. Adding back the undo command override (only when WFS editor is active). More context on why it's needed on previous PR, which was approved and merged previously. Verified that the command only applies to WFS editor and with this undo behaviour is fixed
  3. Removing redundant code (verified the integration still works fine)

  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@witness-me witness-me requested a review from a team as a code owner February 24, 2025 22:55
@github-actions
Copy link

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.
  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

let html = `${htmlFileSplit[0]} <head> ${baseTag} ${localeTag} ${darkModeTag} ${tabSizeTag} ${htmlFileSplit[1]}`

const nonce = getRandomString()
const localDevURL = isLocalDev ? localhost : ''
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this part no longer relevant?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We actually never used this for WFS integration as we never added custom scripts on webview side - I think I originally implemented it the same way as it was for Threat composer editor (code).

Our integration works fine without this extra code, similar to how InfraComposer integration works (code)

@jpinkney-aws jpinkney-aws merged commit d8aee7b into aws:feature/stepfunctions-workflow Feb 26, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants