telemetry(amazonq): createUpload metric for scans #6715
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ctlai95
commented
Mar 4, 2025
Comment on lines
+222
to
+223
| ...(!this.state.requestId ? { requestId: getRequestId(err) } : {}), | ||
| ...(!this.state.httpStatusCode ? { httpStatusCode: getHttpStatusCode(err) } : {}), |
Contributor
Author
There was a problem hiding this comment.
Making this change to allow requestId and httpStatusCode to be set explicitly before the stop method is invoked. Otherwise it will silently get removed if err is not the correct format.
laileni-aws
reviewed
Mar 4, 2025
| "type": "string", | ||
| "description": "The intent of the upload", | ||
| "allowedValues": [ | ||
| "TRANSFORMATION", |
Contributor
There was a problem hiding this comment.
nit: Can you add TEST_GENERATION as allowed value, if not I can add this as part of next PR's or while shipping this to common package.
Contributor
There was a problem hiding this comment.
NVM, I will make change for UTG.
Thanks @ctlai95
laileni-aws
approved these changes
Mar 4, 2025
nkomonen-amazon
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Some users are reporting S3 upload failures but we don't have the requestIds to investigate further.
Solution
Emit
amazonq_createUploadmetric with requestIdsfeature/xbranches will not be squash-merged at release time.