telemetry(amazonq): update to new module metric name #6717
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Problem: Updated the telemetry types and had to change an existing name to match the new one. Solution: use `toolkit_didLoadModule` to indicate that the module successfully opened. In certain cases we will want to use `toolkit_willOpenModule` to indicate the start of it, but because it doesn't look like that was used already we can ignore it for now and revisit later. Signed-off-by: nkomonen-amazon <[email protected]>
nkomonen-amazon
force-pushed
the
moduleLoad
branch
from
a37a12d to
b6c0c66
Compare
hayemaxi
approved these changes
Mar 5, 2025
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Updated the telemetry types and had to change an existing name to match the new one.
Solution:
use
toolkit_didLoadModuleto indicate that the module successfully opened. In certain cases we will want to usetoolkit_willOpenModuleto indicate the start of it, but because it doesn't look like that was used already we can ignore it for now and revisit later.feature/xbranches will not be squash-merged at release time.