Skip to content

fix(amazonq): increase scan timeout threshold #6765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 11, 2025
Merged

fix(amazonq): increase scan timeout threshold #6765

merged 2 commits into from
Mar 11, 2025

Conversation

@zuoyaofu
Copy link
Contributor

@zuoyaofu zuoyaofu commented Mar 11, 2025 •
edited
Loading

Problem

  • we are getting quite a noteworthy amount of scan timeout errors on the front end.

Solution

  • increase front-end timeout
  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions
Copy link

github-actions bot commented Mar 11, 2025

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.

@zuoyaofu zuoyaofu marked this pull request as ready for review March 11, 2025 20:51
@zuoyaofu zuoyaofu requested review from a team as code owners March 11, 2025 20:51
nkomonen-amazon
nkomonen-amazon reviewed Mar 11, 2025
View reviewed changes
packages/core/src/codewhisperer/models/constants.ts
export const contextTruncationTimeoutSeconds = 10

export const standardScanTimeoutMs = 600_000 // 10 minutes
export const standardScanTimeoutMs = 900_000 // 15 minutes
Copy link
Contributor

@nkomonen-amazon nkomonen-amazon Mar 11, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I typically prefer breaking down the calculation for better readability, 60_000 * 15

@zuoyaofu zuoyaofu merged commit 6d5ec44 into aws:master Mar 11, 2025
16 of 17 checks passed
@zuoyaofu zuoyaofu deleted the change-timeout branch April 10, 2025 21:28
@zuoyaofu zuoyaofu mentioned this pull request Apr 25, 2025
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@atonaamz atonaamz atonaamz approved these changes

@nkomonen-amazon nkomonen-amazon nkomonen-amazon approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zuoyaofu @atonaamz @nkomonen-amazon