refactor(cwl): migrate client to sdkv3 #6796
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/runIntegrationTests |
jpinkney-aws
approved these changes
Mar 17, 2025
| logGroupInfo: CloudWatchLogsGroupInfo, | ||
| parameters: CloudWatchLogsParameters, | ||
| nextToken?: CloudWatchLogs.NextToken | ||
| nextToken?: string |
Contributor
There was a problem hiding this comment.
I guess the v3 loses these types?
Contributor
Author
There was a problem hiding this comment.
Yeah, they were simple aliases in v2 so not losing anything meaningful. https://github.com/aws/aws-sdk-js/blob/966fa6c316dbb11ca9277564ff7120e6b16467f4/clients/cloudwatchlogs.d.ts#L2330
jpinkney-aws
pushed a commit
to jpinkney-aws/aws-toolkit-vscode
that referenced
this pull request
Mar 20, 2025
## Problem still uses v2 ## Solution - straight forward migration ## Verification - Tested log tailing. - Tested search functionality. - Inspected individual log streams from a log group. - Used the codelenses to load more or fewer events. - Filtered logs based on keyword. - ## Future Work - each consumer of CWL client implements their own pagination. This should be done once within the client. --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
still uses v2
Solution
Verification
Future Work
feature/xbranches will not be squash-merged at release time.