Skip to content

feat(amazonq): support import through language server #6896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
justinmk3 merged 1 commit into from
Apr 1, 2025
Merged

feat(amazonq): support import through language server #6896

justinmk3 merged 1 commit into from
Apr 1, 2025

Conversation

@zixlin7
Copy link
Contributor

@zixlin7 zixlin7 commented Apr 1, 2025

Problem

need to support imports through language server

Solution

  • show code lens if suggestion has imports
  • on accept of the suggestion, also insert the import
  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions
Copy link

github-actions bot commented Apr 1, 2025

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.
  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@zixlin7 zixlin7 marked this pull request as ready for review April 1, 2025 00:28
@zixlin7 zixlin7 requested review from a team as code owners April 1, 2025 00:28
@justinmk3 justinmk3 merged commit 708f538 into aws:master Apr 1, 2025
29 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jpinkney-aws jpinkney-aws jpinkney-aws approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zixlin7 @jpinkney-aws @justinmk3