Skip to content

fix(chat): fix for chat history for multuple tabs and user tool ignore #6906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zixlin7 merged 2 commits into from
Apr 1, 2025
Merged

fix(chat): fix for chat history for multuple tabs and user tool ignore #6906

zixlin7 merged 2 commits into from
Apr 1, 2025

Conversation

@ashishrp-aws
Copy link
Contributor

@ashishrp-aws ashishrp-aws commented Apr 1, 2025

Problem

  • History storage not set up for each tabs.
  • If user ignores tool use and moves on, then request fails.

Solution

  • Fixed chat history for multiple tab support
  • User cancellation message is added to request in this case.
  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ashishrp-aws ashishrp-aws requested review from a team as code owners April 1, 2025 20:36
@ashishrp-aws ashishrp-aws changed the base branch from master to feature/agentic-chat April 1, 2025 20:36
@github-actions
Copy link

github-actions bot commented Apr 1, 2025

  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

ctlai95
ctlai95 reviewed Apr 1, 2025
View reviewed changes
@github-actions
Copy link

github-actions bot commented Apr 1, 2025

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.
  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

ctlai95
ctlai95 reviewed Apr 1, 2025
View reviewed changes
packages/core/src/codewhispererChat/controllers/chat/controller.ts
Comment on lines +1342 to 1344
if (fixedHistoryMessage.userInputMessage?.userInputMessageContext) {
triggerPayload.toolResults = fixedHistoryMessage.userInputMessage.userInputMessageContext.toolResults
}
Copy link
Contributor

@ctlai95 ctlai95 Apr 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why can't we do this inside fixHistory?

Copy link
Contributor Author

@ashishrp-aws ashishrp-aws Apr 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can but i'm not sending triggerPayload to fixHistory. fixHistory could be used for other operations, so i set it up to take in only ChatMessage

@ashishrp-aws
Copy link
Contributor Author

ashishrp-aws commented Apr 1, 2025

/retryBuilds

@zixlin7 zixlin7 merged commit 62214ee into aws:feature/agentic-chat Apr 1, 2025
22 checks passed
@ashishrp-aws ashishrp-aws deleted the feature/agentic-chat-merge branch April 2, 2025 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ctlai95 ctlai95 ctlai95 left review comments

+2 more reviewers

@zixlin7 zixlin7 zixlin7 approved these changes

@tsmithsz tsmithsz tsmithsz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ashishrp-aws @ctlai95 @zixlin7 @tsmithsz