Skip to content

Conversation

@jguoamz
Copy link
Contributor

@jguoamz jguoamz commented Apr 3, 2025

Problem

  • ListDirectory tool will get called too many times if the directory has many subdirectories

Solution

  • Add maxDepth parameter to ListDirectory tool to allow recursively listing directories
  • Minor fix on the tool_spec

  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jguoamz jguoamz changed the title Add maxDepth parameter to ListDirectory tool fix(chat): Add maxDepth parameter to ListDirectory tool Apr 3, 2025
@jguoamz jguoamz closed this Apr 3, 2025
@jguoamz jguoamz reopened this Apr 3, 2025
@github-actions
Copy link

github-actions bot commented Apr 3, 2025

  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@jguoamz jguoamz marked this pull request as ready for review April 3, 2025 01:46
@jguoamz jguoamz requested review from a team as code owners April 3, 2025 01:46
@jguoamz jguoamz force-pushed the listDirectoryDepth branch 2 times, most recently from fef1b88 to 80c8613 Compare April 3, 2025 21:39
@jguoamz jguoamz force-pushed the listDirectoryDepth branch from 80c8613 to cbb6024 Compare April 3, 2025 21:44
@zixlin7 zixlin7 merged commit a8672fd into aws:feature/agentic-chat Apr 3, 2025
21 of 22 checks passed
@jguoamz jguoamz deleted the listDirectoryDepth branch April 3, 2025 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants