Skip to content

Conversation

@vicheey
Copy link
Contributor

@vicheey vicheey commented Apr 3, 2025

Problem

fix #6913

Solution

Move the spy instantiation closer to reduce side effects. Add delay before start running command so additional for clean up to reduce chance of flakiness. Change assertion from true/false to count comparison to give more info for debugging in case the flakiness persists into the future.


  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@vicheey vicheey requested a review from a team as a code owner April 3, 2025 07:07
@github-actions
Copy link

github-actions bot commented Apr 3, 2025

  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.


// Invoke sync command from command palette
await runBuild()
// Instead of await runBuild(), prefer this to avoid flakiness due to race condition
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the race condition? Could it affect users or is it test specific?

@justinmk3 justinmk3 merged commit b097fbf into aws:master Apr 3, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

unreliable test: "SAM runBuild"

3 participants