Skip to content

Conversation

@vicheey
Copy link
Contributor

@vicheey vicheey commented Apr 3, 2025

Problem

fix #6921

Solution

Refactor the tests for cleaner creating and deletion template.yaml file.

  • Scope and group tests cases based on required starting template.
  • Update assertion and error message.

  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@vicheey vicheey requested a review from a team as a code owner April 3, 2025 17:41
@github-actions
Copy link

github-actions bot commented Apr 3, 2025

  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@justinmk3
Copy link
Contributor

Is this CI failure unrelated to these changes?

AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:

2 !== 1

    at verifyCorrectDependencyCall (/codebuild/output/src1485263156/src/github.com/aws/aws-toolkit-vscode/packages/core/src/test/shared/sam/build.test.ts:343:20)
    at Context.<anonymous> (/codebuild/output/src1485263156/src/github.com/aws/aws-toolkit-vscode/packages/core/src/test/shared/sam/build.test.ts:530:13)

      + expected - actual

      -2
      +1

@justinmk3 justinmk3 merged commit 91859e2 into aws:master Apr 3, 2025
28 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

unreliable test: appbuilder walkthrough download serverlessland proj

2 participants