Skip to content

Conversation

@Randall-Jiang
Copy link
Contributor

@Randall-Jiang Randall-Jiang commented Apr 4, 2025

Problem

  1. On previous output console, the UI shows bash, now it need to be shell
  2. For writing the file, there is no spinner so it has perceived latency illusion.
    image
  3. For build failed case, the build log won't show up in code block and not formatted

Solution

  1. Updated the console UI text to "shell".
  2. Identified the issue where the toolUseEvent wasn't stopping during file writing, preventing the spinner from appearing in the chat. Resolved by adding an if statement to handle the toolUseInput case appropriately.
  3. Formatted the output for stderr.
Screenshot 2025-04-03 at 5 31 13 PM
  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Randall-Jiang Randall-Jiang requested review from a team as code owners April 4, 2025 00:28
@github-actions
Copy link

github-actions bot commented Apr 4, 2025

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.
  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@ammathu ammathu requested a review from ctlai95 April 4, 2025 05:08
@Randall-Jiang Randall-Jiang requested a review from zixlin7 April 4, 2025 17:35
@Randall-Jiang Randall-Jiang force-pushed the my-feature-agentic branch 2 times, most recently from a6a4c75 to 06864a9 Compare April 5, 2025 00:40
@zixlin7 zixlin7 merged commit 69de65c into aws:feature/agentic-chat Apr 5, 2025
21 of 22 checks passed
requestId?: string
}

export function extractErrorInfo(error: any): MessageErrorInfo {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for thinking about shared utils, but this is specific to CW client, so it should live in packages/core/src/shared/clients/codewhispererChatClient.ts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants