Skip to content

fix(amazonq): Fix Q chat webview freezes & crash #6943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix(amazonq): Fix Q chat webview freezes & crash #6943

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/amazonq/.changes/next-release/Bug Fix-65c16a0a-8891-48ea-83bf-3e86ae538d23.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
{
"type": "Bug Fix",
"description": "Fix bug when Q chat webview occasionally freezes and become gray"
}
2 changes: 1 addition & 1 deletion packages/core/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -524,7 +524,7 @@
"@aws-sdk/s3-request-presigner": "<3.731.0",
"@aws-sdk/smithy-client": "<3.731.0",
"@aws-sdk/util-arn-parser": "<3.731.0",
"@aws/mynah-ui": "^4.27.0",
"@aws/mynah-ui": "^4.28.0",
"@gerhobbelt/gitignore-parser": "^0.2.0-9",
"@iarna/toml": "^2.2.5",
"@smithy/fetch-http-handler": "^5.0.1",
Expand Down
8 changes: 1 addition & 7 deletions packages/core/src/codewhispererChat/controllers/chat/controller.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -577,13 +577,7 @@ export class ChatController {
id: contextCommandItem.id,
icon: 'folder' as MynahIconsType,
})
}
// TODO: Remove the limit of 25k once the performance issue of mynahUI in webview is fixed.
else if (
contextCommandItem.symbol &&
symbolsCmd.children &&
symbolsCmd.children[0].commands.length < 25_000
) {
} else if (contextCommandItem.symbol && symbolsCmd.children) {
symbolsCmd.children?.[0].commands.push({
command: contextCommandItem.symbol.name,
description: `${contextCommandItem.symbol.kind}, ${path.join(wsFolderName, contextCommandItem.relativePath)}, L${contextCommandItem.symbol.range.start.line}-${contextCommandItem.symbol.range.end.line}`,
Expand Down
Loading