refactor(chat): simplify history logic #6946
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
chungjac
approved these changes
Apr 5, 2025
jguoamz
approved these changes
Apr 5, 2025
laileni-aws
added a commit
to laileni-aws/aws-toolkit-vscode
that referenced
this pull request
Apr 5, 2025
* pair programming mode * pairProgrammingModeOn boolean * use session in chatHistory * revert chatHistory * client side toolName validation * refactor(chat): simplify history logic (aws#6946) ## Problem History logic cleanup ## Solution - History does not need to be in triggerPayload - ChatHistory does not need tools - We don't need to create and maintain a separate newUserMessage object --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license. --------- Co-authored-by: Jacob Chung <[email protected]> Co-authored-by: Tai Lai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
History logic cleanup
Solution
feature/xbranches will not be squash-merged at release time.