feat(chat): Add header for execute shell command #6948
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
yueny2020
force-pushed
the
feature/agentic-chat
branch
from
29fffec to
e358157
Compare
laileni-aws
reviewed
Apr 5, 2025
| }) | ||
| ) | ||
| // Need separate id for read tool and safe bash command execution as 'run-shell-command' id is required to state in cwChatConnector.ts which will impact generic tool execution. | ||
| if (tool.type === ToolType.ExecuteBash) { |
Contributor
There was a problem hiding this comment.
const actionId = tool.type === ToolType.ExecuteBash
? 'run-shell-command'
: 'generic-tool-execution'
this.dispatcher.sendCustomFormActionMessage(
new CustomFormActionMessage(tabID, { id: actionId })
)
Contributor
Author
There was a problem hiding this comment.
can do it in next pr.
laileni-aws
reviewed
Apr 5, 2025
| buttons: toolUse?.name === ToolType.FsWrite ? undefined : buttons, | ||
| fullWidth: toolUse?.name === ToolType.FsWrite, | ||
| padding: !(toolUse?.name === ToolType.FsWrite), | ||
| buttons: |
Contributor
There was a problem hiding this comment.
We can keep buttons: undefined. Buttons is used only by fsWrite and ExecuteBash
Contributor
Author
There was a problem hiding this comment.
you mean the current check is right, but we can simplify it, right?
Contributor
Author
There was a problem hiding this comment.
if yes, then i can do it in next pr.
laileni-aws
reviewed
Apr 5, 2025
| id: 'confirmed-tool-use', | ||
| case 'run-shell-command': | ||
| answer.header = { | ||
| icon: 'code-block' as MynahIconsType, |
Contributor
There was a problem hiding this comment.
I think we don't need this icon and body. Please follow same approach as accept-code-diff.
Contributor
Author
There was a problem hiding this comment.
why we don't need body and icon? or i missed some UI?
Contributor
There was a problem hiding this comment.
Use the tyrone StoreItem to get the body and icon
laileni-aws
approved these changes
Apr 5, 2025
laileni-aws
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Solution
when shell command un-destructive, directly execute the command
when when shell command destructive, customer can decide to run or reject the command execution
-- reject
-- run
feature/xbranches will not be squash-merged at release time.