-
Notifications
You must be signed in to change notification settings - Fork 748
fix(chat): agentic chat working stop #6950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(chat): agentic chat working stop #6950
Conversation
|
|
| if ( | ||
| this.history.at(-1)?.assistantResponseMessage?.content === '' && | ||
| this.history.at(-1)?.assistantResponseMessage?.toolUses === undefined | ||
| ) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you please explain what this do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In some scenarios we are breaking the breaking the assistant response and that empty message is being pushed to chat history as assistant response. so in that specific case, we are correcting the history by clearing up the recent messages. Also making sure that to not toolUse messages with empty content
Problem
Conversation needs stop button to stop the agentic chat loop and conversations topping for new user prompt.
Solution
feature/xbranches will not be squash-merged at release time.