feat(amazonq): Handle disclaimer acknowledgement #6951
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as off-topic.
This comment was marked as off-topic.
justinmk3
force-pushed
the
fixdisclaimer
branch
3 times, most recently
from
5d255c9 to
4b8e6df
Compare
justinmk3
force-pushed
the
fixdisclaimer
branch
2 times, most recently
from
bc9557e to
a2cc13d
Compare
Problem: Webpack fails on the parent commit: 2025-04-07T17:25:48.4129595Z Error: Cannot find module './globalState' 2025-04-07T17:25:48.4148372Z at webpackMissingModule (file:///…/packages/amazonq/dist/test/web/testRunnerWebCore.js#vscode-extension:159675:92) Solution: Avoid importing `'aws-core-vscode/amazonq'` in `webviewProvider.ts`. `AmazonQPromptSettings` is intended to have application-specific logic, so move the logic there and drop the special `disclaimer.ts` module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
continues #6825
feature/xbranches will not be squash-merged at release time.