Skip to content

Conversation

@parameja1
Copy link
Contributor

@parameja1 parameja1 commented Apr 7, 2025

Problem

SageMaker AI and Unified Studio currently in prod uses version 1.32 and with manual upgrade to the newer version >1.54, observing agentic prompt added along with new commands /test, /review, /doc which are not supported by SageMaker apps

Solution

  1. SageMaker doesnt support currently /dev, /transform commands and in addition to that disabling the above listed agentic Q commands that are not supported in SageMaker apps(both SMAI and SMUS).
  2. Also disabling the agentic options from quick pick items
  3. Skip agentic welcome prompt

Testing
npm run compile && npm run package and tested with the artefacts manually in SMUS and SMAI

  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

and SMUS. Also disabling the options from quick pick items and skip
agentic welcome prompt
npm run package and tested with the artefacts manually in SMUS and SMAI
@parameja1 parameja1 requested review from a team as code owners April 7, 2025 21:47
@github-actions
Copy link

github-actions bot commented Apr 7, 2025

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.

await setContext('aws.toolkit.amazonq.dismissed', true)

// set context var to check if its SageMaker AI or not
await setContext('aws.isSageMaker', isSageMaker())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 This is done for Toolkit here:

if (!isSageMaker()) {
await setContext('aws.isSageMaker', false)
await codecatalyst.activate(extContext)
} else {
await setContext('aws.isSageMaker', true)
}

but currently packages/amazonq/src/extension.ts does not share a "common" startup logic w/ Toolkit, so we need this redundant code here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack, thanks for adding the details Justin

@justinmk3 justinmk3 merged commit a96a73e into aws:master Apr 8, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants