Skip to content

Conversation

@jguoamz
Copy link
Contributor

@jguoamz jguoamz commented Apr 8, 2025

Problem

  • fix(chat): Remove enforceMaxSize from fsRead
    • It had the wrong limit size of 30720

Solution

  • Remove it since we have toolResult size validation after executing the tool already

  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions
Copy link

github-actions bot commented Apr 8, 2025

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.
  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@jguoamz jguoamz force-pushed the maxToolResponse branch 3 times, most recently from 4b0f65a to a7b015a Compare April 8, 2025 01:22
@jguoamz jguoamz marked this pull request as ready for review April 8, 2025 01:46
@jguoamz jguoamz requested review from a team as code owners April 8, 2025 01:46
Copy link
Contributor

@Hweinstock Hweinstock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zixlin7 zixlin7 merged commit 3def040 into aws:feature/agentic-chat Apr 8, 2025
22 checks passed
@jguoamz jguoamz deleted the maxToolResponse branch April 16, 2025 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants