Skip to content

fix(amazonq): "failed to run command" #6982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 9, 2025
Merged

fix(amazonq): "failed to run command" #6982

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/amazonq/.changes/next-release/Bug Fix-c6521d8e-639d-4672-b5fb-354c91c526be.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
{
"type": "Bug Fix",
"description": "\"failed to run command\" error"
}
5 changes: 2 additions & 3 deletions packages/amazonq/src/lsp/chat/commands.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
* SPDX-License-Identifier: Apache-2.0
*/

import * as vscode from 'vscode'
import { Commands, globals } from 'aws-core-vscode/shared'
import { window } from 'vscode'
import { AmazonQChatViewProvider } from './webviewProvider'
Expand Down Expand Up @@ -74,6 +73,6 @@ function registerGenericCommand(commandName: string, genericCommand: string, pro
* Instead, we just create our own as a temporary solution
*/
async function focusAmazonQPanel() {
await vscode.commands.executeCommand('aws.amazonq.AmazonQChatView.focus')
await vscode.commands.executeCommand('aws.amazonq.AmazonCommonAuth.focus')
await Commands.tryExecute('aws.amazonq.AmazonQChatView.focus')
await Commands.tryExecute('aws.amazonq.AmazonCommonAuth.focus')
}
4 changes: 2 additions & 2 deletions packages/core/src/amazonqFeatureDev/controllers/chat/controller.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ import { AuthUtil } from '../../../codewhisperer/util/authUtil'
import { AuthController } from '../../../amazonq/auth/controller'
import { getLogger } from '../../../shared/logger/logger'
import { submitFeedback } from '../../../feedback/vue/submitFeedback'
import { placeholder } from '../../../shared/vscode/commands2'
import { Commands, placeholder } from '../../../shared/vscode/commands2'
import { EditorContentController } from '../../../amazonq/commons/controllers/contentController'
import { openUrl } from '../../../shared/utilities/vsCodeUtils'
import { checkForDevFile, getPathsFromZipFilePath } from '../../../amazonq/util/files'
Expand Down Expand Up @@ -579,7 +579,7 @@ export class FeatureDevController {
open
)
if (resp === open) {
await vscode.commands.executeCommand('aws.amazonq.AmazonQChatView.focus')
await Commands.tryExecute('aws.amazonq.AmazonQChatView.focus')
// TODO add focusing on the specific tab once that's implemented
}
}
Expand Down
5 changes: 2 additions & 3 deletions packages/core/src/codewhispererChat/commands/registerCommands.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ import { commandPalette } from '../../codewhisperer/commands/types'
import { CodeScanIssue } from '../../codewhisperer/models/model'
import { Commands, VsCodeCommandArg, placeholder } from '../../shared/vscode/commands2'
import { ChatControllerMessagePublishers } from '../controllers/chat/controller'
import vscode from 'vscode'

/**
* Opens the Amazon Q panel, showing the correct View that should
Expand All @@ -25,8 +24,8 @@ export const focusAmazonQPanel = Commands.declare(
* So when we try to focus the following Views, only one will show depending
* on the context.
*/
await vscode.commands.executeCommand('aws.amazonq.AmazonQChatView.focus')
await vscode.commands.executeCommand('aws.amazonq.AmazonCommonAuth.focus')
await Commands.tryExecute('aws.amazonq.AmazonQChatView.focus')
await Commands.tryExecute('aws.amazonq.AmazonCommonAuth.focus')
}
)

Expand Down
Loading