Skip to content

Conversation

@jguoamz
Copy link
Contributor

@jguoamz jguoamz commented Apr 11, 2025

Problem

  • Large repo can cause result of listDirectory to contain more than 500K characters

Solution

  • Reduce maxToolResponseSize from 800K to 200K
  • Updated fsRead to read every 4000 lines if the file is too big
  • Updated fsWrite to include explanation optional parameter

  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions
Copy link

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.
  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@jguoamz jguoamz force-pushed the toolSize branch 2 times, most recently from 8d03425 to f81a3b5 Compare April 11, 2025 01:53
@jguoamz jguoamz changed the title fix(chat): Reduce maxToolResponseSize from 800K to 100K fix(chat): Reduce maxToolResponseSize from 800K to 200K Apr 11, 2025
@jguoamz jguoamz marked this pull request as ready for review April 11, 2025 02:10
@jguoamz jguoamz requested review from a team as code owners April 11, 2025 02:10
@mr-lee mr-lee merged commit 63a28b8 into aws:feature/agentic-chat Apr 11, 2025
16 of 22 checks passed
@jguoamz jguoamz deleted the toolSize branch April 11, 2025 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants