Skip to content

Conversation

@zuoyaofu
Copy link
Contributor

Problem

  1. document.lineAt would error due to line out of bounds.
  2. File uploaded for codeFix is not the same as the one in editor

Solution

  1. Remove document.lineAt logic
  2. Ensure dirty file is saved before zipping.

  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@zuoyaofu zuoyaofu requested review from a team as code owners April 11, 2025 21:22
@github-actions
Copy link

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.

@justinmk3
Copy link
Contributor

Can this wait until next week's release?

@zuoyaofu
Copy link
Contributor Author

Can this wait until next week's release?

Yes, this is not as urgent.

@zuoyaofu zuoyaofu merged commit dd14b98 into aws:master Apr 11, 2025
30 of 31 checks passed
@zuoyaofu zuoyaofu deleted the code-fix-line branch April 11, 2025 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants