telemetry(chat): request id and error message in error metric #7045
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
laileni-aws
reviewed
Apr 15, 2025
packages/core/src/codewhispererChat/controllers/chat/controller.ts
Outdated
Show resolved
Hide resolved
laileni-aws
reviewed
Apr 15, 2025
justinmk3
reviewed
Apr 15, 2025
packages/core/src/codewhispererChat/controllers/chat/telemetryHelper.ts
Outdated
Show resolved
Hide resolved
justinmk3
reviewed
Apr 15, 2025
packages/core/src/codewhispererChat/controllers/chat/telemetryHelper.ts
Outdated
Show resolved
Hide resolved
justinmk3
approved these changes
Apr 15, 2025
laileni-aws
reviewed
Apr 15, 2025
Contributor
Author
|
/retrybuilds |
laileni-aws
approved these changes
Apr 15, 2025
Randall-Jiang
pushed a commit
to Randall-Jiang/aws-toolkit-vscode
that referenced
this pull request
Apr 15, 2025
## Problem - do not have `requestID` and `errorMessage` in amazonq_messageResponseError ## Solution - emit amazonq_messageResponseError event with `requestID` and `errorMessage` --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license.
jpinkney-aws
pushed a commit
to aws/language-servers
that referenced
this pull request
Apr 23, 2025
#### for context, here is the agentic-chat branch pr which i am porting to `language-servers`: aws/aws-toolkit-vscode#7045 ## Problem - do not have requestID and errorMessage in amazonq_messageResponseError ## Solution - emit amazonq_messageResponseError event with requestID and errorMessage - ported `getTelemetryReasonDesc` and all of its corresponding helpers from: https://github.com/aws/aws-toolkit-vscode/blob/master/packages/core/src/shared/errors.ts#L455
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
requestIDanderrorMessagein amazonq_messageResponseErrorSolution
requestIDanderrorMessagefeature/xbranches will not be squash-merged at release time.