refactor(amazonq): Pass mynah references to ui handlers #7046
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
justinmk3
reviewed
Apr 15, 2025
justinmk3
approved these changes
Apr 15, 2025
|
|
||
| const addChatItem = (tabID: string, messageId: string, options: any[]) => { | ||
| this.mynahUI.addChatItem(tabID, { | ||
| this.mynahUI?.addChatItem(tabID, { |
Contributor
There was a problem hiding this comment.
Is this more accurate since there shouldn't be a scenario that this is undefined when run???
Suggested change
| this.mynahUI?.addChatItem(tabID, { | |
| this.mynahUI!.addChatItem(tabID, { |
nkomonen-amazon
approved these changes
Apr 15, 2025
jpinkney-aws
added a commit
that referenced
this pull request
Apr 16, 2025
## Problem
- we want a chat mode where agents are served by the local extension
while the regular "Chat" is served by flare
## Solution
- register mynah ui webview providers depending on lsp/normal
implementation
- temporarily disable the lsp (explain, fix, etc) commands, since they
are also registered in the normal "agent" flow
- redirect agent messages to the correct chat handler on the UI side
- redirect UI messages meant for agents to the extension side
- refactor main.ts so that it can be used by both the regular
implementation and the lsp one ~(I'll open a seperate PR to merge this
into master, since it's going to be a pain to maintain)~
- #7033
- pass in references to mynah handlers so that mynah ref injection can
happen after in flare
- #7046
Depends on ~#7033,
#7046
Related to aws/language-servers#962
---
- Treat all work as PUBLIC. Private `feature/x` branches will not be
squash-merged at release time.
- Your code changes must meet the guidelines in
[CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines).
- License: I confirm that my contribution is made under the terms of the
Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Solution
feature/xbranches will not be squash-merged at release time.