test(amazonq): full E2E test for /review #7047
Conversation
|
/runIntegrationTests |
|
/runIntegrationTests |
|
/runIntegrationTests |
1 similar comment
|
/runIntegrationTests |
|
/runIntegrationTests |
|
/runIntegrationTests |
1 similar comment
|
/runIntegrationTests |
|
/runIntegrationTests |
1 similar comment
|
/runIntegrationTests |
|
/runIntegrationTests |
|
/runIntegrationTests |
|
/runIntegrationTests |
|
/runIntegrationTests |
|
/runIntegrationTests |
| function assertAtLeastOneLLMFindings(securityDiagnostics: vscode.Diagnostic[]) { | ||
| const readabilityIssuesCount = matchingSecurityDiagnosticCount( | ||
| securityDiagnostics, | ||
| 'Readability and maintainability issues detected.' |
There was a problem hiding this comment.
How do we know that these are LLM findings?
There was a problem hiding this comment.
| const targetFilePath: string = issue instanceof IssueItem ? issue.filePath : filePath | ||
| await showSecurityIssueWebview(context.extensionContext, targetIssue, targetFilePath) | ||
|
|
||
| if (targetIssue.suggestedFixes.length === 0) { |
There was a problem hiding this comment.
what is this change for?
There was a problem hiding this comment.
This is because for some reason, emitting telemetry on gitHub test environment will error. I was not able to root cause after many tries, so a quick fix would be first execute get code fix, and then send telemetry.
There was a problem hiding this comment.
emitting telemetry on gitHub test environment will error
what error exactly?
There was a problem hiding this comment.
Let me merge for now, and answer this question in a bit.
| range | ||
| ) | ||
|
|
||
| console.log('first diag', sampleDiagnostic) |
There was a problem hiding this comment.
can we remove these console logs?
|
/runIntegrationTests |
4 participants
Problem
Create E2E test for /review
Solution
feature/xbranches will not be squash-merged at release time.