Skip to content

Conversation

@Randall-Jiang
Copy link
Contributor

Problem

Right now, when user reject executing command, chat would send the reject message to LLM and LLM would response. The loop would still continue
Screenshot 2025-04-15 at 11 36 15 AM

Solution

Screenshot 2025-04-15 at 11 44 57 AM
  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Randall-Jiang Randall-Jiang requested review from a team as code owners April 15, 2025 18:45
@github-actions
Copy link

  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@Randall-Jiang Randall-Jiang reopened this Apr 15, 2025
@Randall-Jiang Randall-Jiang changed the base branch from master to feature/agentic-chat April 15, 2025 18:52
Randall-Jiang and others added 3 commits April 15, 2025 12:45
## Problem
The Ux design does not meet the requirement

## Solution
Make the undo a clickable button and change the string when user reject
the generated code

![image](https://github.com/user-attachments/assets/53bf59e8-ffc6-45ba-9944-236e4e3bae69)

---

- Treat all work as PUBLIC. Private `feature/x` branches will not be
squash-merged at release time.
- Your code changes must meet the guidelines in
[CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines).
- License: I confirm that my contribution is made under the terms of the
Apache 2.0 license.
## Problem
- do not have `requestID` and `errorMessage` in
amazonq_messageResponseError

## Solution
- emit amazonq_messageResponseError event with `requestID` and
`errorMessage`

---

- Treat all work as PUBLIC. Private `feature/x` branches will not be
squash-merged at release time.
- Your code changes must meet the guidelines in
[CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines).
- License: I confirm that my contribution is made under the terms of the
Apache 2.0 license.
@github-actions
Copy link

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.
  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@zixlin7 zixlin7 merged commit ad148d4 into aws:feature/agentic-chat Apr 15, 2025
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants