Skip to content

fix(chat): fix for stop button for disappearing for subsequent conversations #7053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 15, 2025
Merged

fix(chat): fix for stop button for disappearing for subsequent conversations #7053

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8046848
Fix for stop button for disappearing for subsequent conversations
ashishrp-aws Apr 15, 2025
f6f30e4
revert for chatDb
ashishrp-aws Apr 15, 2025
40e3f3d
fix for opening prompt while agentic loop and lint fix for duplicate
ashishrp-aws Apr 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/core/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -525,7 +525,7 @@
"@aws-sdk/s3-request-presigner": "<3.731.0",
"@aws-sdk/smithy-client": "<3.731.0",
"@aws-sdk/util-arn-parser": "<3.731.0",
"@aws/mynah-ui": "^4.31.0-beta.2",
"@aws/mynah-ui": "^4.31.0-beta.3",
"@gerhobbelt/gitignore-parser": "^0.2.0-9",
"@iarna/toml": "^2.2.5",
"@smithy/fetch-http-handler": "^5.0.1",
Expand Down
1 change: 0 additions & 1 deletion packages/core/src/amazonq/webview/ui/followUps/handler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@ export class FollowUpInteractionHandler {
if (followUp.prompt !== undefined) {
this.mynahUI.updateStore(tabID, {
loadingChat: true,
cancelButtonWhenLoading: false,
promptInputDisabledState: true,
})
this.mynahUI.addChatItem(tabID, {
Expand Down
1 change: 0 additions & 1 deletion packages/core/src/amazonq/webview/ui/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -471,7 +471,6 @@ export const createMynahUI = (
) {
mynahUI.updateStore(tabID, {
loadingChat: true,
cancelButtonWhenLoading: false,
promptInputDisabledState: true,
})

Expand Down
3 changes: 1 addition & 2 deletions packages/core/src/amazonq/webview/ui/messages/controller.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,6 @@ export class MessageController {

this.mynahUI.updateStore(selectedTab.id, {
loadingChat: true,
cancelButtonWhenLoading: false,
promptInputDisabledState: true,
})
this.mynahUI.addChatItem(selectedTab.id, message)
Expand Down Expand Up @@ -120,7 +119,7 @@ export class MessageController {

this.mynahUI.updateStore(newTabID, {
loadingChat: true,
cancelButtonWhenLoading: false,
// cancelButtonWhenLoading: false,
promptInputDisabledState: true,
})

Expand Down
1 change: 0 additions & 1 deletion packages/core/src/amazonq/webview/ui/messages/handler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ export class TextMessageHandler {

this.mynahUI.updateStore(tabID, {
loadingChat: true,
cancelButtonWhenLoading: false,
promptInputDisabledState: true,
})

Expand Down
3 changes: 0 additions & 3 deletions packages/core/src/amazonq/webview/ui/quickActions/handler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,6 @@ export class QuickActionHandler {

this.mynahUI.updateStore(affectedTabId, {
loadingChat: true,
cancelButtonWhenLoading: false,
promptInputDisabledState: true,
})

Expand Down Expand Up @@ -310,7 +309,6 @@ export class QuickActionHandler {
if (currentTabType !== 'unknown' && currentTabType !== 'welcome') {
affectedTabId = this.mynahUI.updateStore('', {
loadingChat: true,
cancelButtonWhenLoading: false,
})
}

Expand All @@ -335,7 +333,6 @@ export class QuickActionHandler {
// disable chat prompt
this.mynahUI.updateStore(affectedTabId, {
loadingChat: true,
cancelButtonWhenLoading: false,
})

this.connector.transform(affectedTabId)
Expand Down
Loading