Skip to content

Conversation

@zuoyaofu
Copy link
Contributor

@zuoyaofu zuoyaofu commented Apr 15, 2025

Problem

We heard from users that auto scans are sometimes causing highlight linting issues where entire IDE is now yellow-underlined with warnings that may sometimes be irrelevant

Solution

We will disable auto scans by default, and user can re-enable in the menu.


  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@zuoyaofu zuoyaofu requested review from a team as code owners April 15, 2025 21:40
@github-actions
Copy link

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.

@zuoyaofu zuoyaofu marked this pull request as draft April 15, 2025 21:45
@zuoyaofu zuoyaofu marked this pull request as ready for review April 15, 2025 23:06
Copy link
Contributor

@jpinkney-aws jpinkney-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a particular reason why this is disabled by default? Is there a way for users to re-enable it? Might be worth highlighting those in the github description

@@ -0,0 +1,4 @@
{
"type": "Removal",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the type correct? We are not removing the feature but just change the setting?

@@ -0,0 +1,4 @@
{
"type": "Removal",
"description": "disable auto-review by default"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we have /review: in description?

@zuoyaofu zuoyaofu requested a review from atonaamz April 18, 2025 23:47
@zuoyaofu zuoyaofu requested a review from jpinkney-aws April 18, 2025 23:54
@jpinkney-aws jpinkney-aws merged commit 1f5f215 into aws:master Apr 19, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants