-
Notifications
You must be signed in to change notification settings - Fork 747
fix(amazonq): Address multiple history bugs #7059
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
zixlin7
merged 1 commit into
aws:feature/agentic-chat
from
tsmithsz:feature/agentic-chat
Apr 17, 2025
Merged
fix(amazonq): Address multiple history bugs #7059
zixlin7
merged 1 commit into
aws:feature/agentic-chat
from
tsmithsz:feature/agentic-chat
Apr 17, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ashishrp-aws
approved these changes
Apr 16, 2025
Contributor
|
/retryBuilds |
laileni-aws
reviewed
Apr 16, 2025
packages/core/src/codewhispererChat/controllers/chat/controller.ts
Outdated
Show resolved
Hide resolved
d6e127f to
6cb4dcb
Compare
laileni-aws
approved these changes
Apr 16, 2025
jguoamz
reviewed
Apr 16, 2025
63da6b2 to
3096750
Compare
jguoamz
reviewed
Apr 16, 2025
packages/core/src/codewhispererChat/controllers/chat/controller.ts
Outdated
Show resolved
Hide resolved
a102557 to
f88f496
Compare
ashishrp-aws
approved these changes
Apr 16, 2025
f88f496 to
591bbc6
Compare
jguoamz
reviewed
Apr 16, 2025
packages/core/src/codewhispererChat/controllers/chat/tabBarController.ts
Show resolved
Hide resolved
591bbc6 to
9dd4523
Compare
jguoamz
reviewed
Apr 16, 2025
9dd4523 to
4efba3f
Compare
jguoamz
approved these changes
Apr 16, 2025
bywang56
pushed a commit
to bywang56/aws-toolkit-vscode
that referenced
this pull request
Apr 17, 2025
## Problem
- `fixHistory` only processes the first conversation associated with the
tab, but there can be multiple. Results in an incomplete history and
messes up the history sent in the request
- We currently delete the entire history for a tab if an exception is
thrown. This is not ideal and leads to customer confusion when they are
not able to continue using their chat history after an error.
- Right-click actions like `Explain this code` fail when preceding
message history contains toolResults. Mynah does not recognize this enum
- Fake messages for tooluse failures are being stored the chat history.
## Solution
- Collect message across all conversation associated with the current
tab and consolidate them into a single conversation
- Remove clearTab() call when exception is thrown
- Do not include history for requests to Mynah
- Remove clearRecentHistory as this is no longer used
- Do not store these fake messages to the chatHistory
## Testing
- Manually tested fixes:
- Chat history still remains after exception is thrown
- Mynah no longer throws exception for right-click action following tool
execution

---
- Treat all work as PUBLIC. Private `feature/x` branches will not be
squash-merged at release time.
- Your code changes must meet the guidelines in
[CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines).
- License: I confirm that my contribution is made under the terms of the
Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
fixHistoryonly processes the first conversation associated with the tab, but there can be multiple. Results in an incomplete history and messes up the history sent in the requestExplain this codefail when preceding message history contains toolResults. Mynah does not recognize this enumSolution
Testing
feature/xbranches will not be squash-merged at release time.