feat(amazonq): Use new auth class using flare identity server for Amazon Q #7062
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
justinmk3
reviewed
Apr 16, 2025
justinmk3
reviewed
Apr 16, 2025
|
|
||
| // Create status bar and reference log UI elements | ||
| void Commands.tryExecute('aws.amazonq.refreshStatusBar') | ||
| void Commands.tryExecute('aws.amazonq.updateReferenceLog') |
Contributor
There was a problem hiding this comment.
I assume it's acceptable that this might be racey?
Contributor
Author
There was a problem hiding this comment.
Yes, if you have a better suggestion let me know!
justinmk3
reviewed
Apr 16, 2025
justinmk3
reviewed
Apr 16, 2025
justinmk3
reviewed
Apr 16, 2025
Co-authored-by: Justin M. Keyes <[email protected]>
hayemaxi
reviewed
Apr 17, 2025
| export const amazonQScopes = [...codeWhispererChatScopes, ...scopesGumby, ...scopesFeatureDev] | ||
|
|
||
| /** AuthProvider interface for the auth functionality needed by RegionProfileManager */ | ||
| export interface IAuthProvider { |
Contributor
There was a problem hiding this comment.
Is this needed? RegionProfileManager is only used for Q. Why not just pass the Q specific utility class for it to use? AuthUtil.
Contributor
Author
There was a problem hiding this comment.
IIUC that's what I attempted initially, but it introduces a circular dependency. See b381d0d#diff-b1c252677272c2b57d62cc5d3da2ee04c060e1db7432c3ea40ab00f9ab26558aR41-R59
Contributor
Author
There was a problem hiding this comment.
We can revisit the implementation as a follow-up, merging the PR to unblock next PR with references
jpinkney-aws
approved these changes
Apr 17, 2025
opieter-aws
merged commit b896e4f
into
aws:feature/amazonqLSP-auth
3 of 22 checks passed
opieter-aws
added a commit
that referenced
this pull request
Apr 21, 2025
…dentity server for Amazon Q (#7088) ## Problem The business logic of auth-related features is complex and implemented separately for all IDEs. Flare/DEXP LSP server has implemented auth that can be reused for all IDEs. The source code was introduced already introduced in #6958 with activation and client updates in #7062. But the references to `AuthUtil` through the codebase weren't updated yet. ## Solution * Update all remaining references to `AuthUtil` in the codebase * All `toolkits` unit tests are passing * Disable telemetry and existing AuthUtil unit tests, to be updated in follow-up PR * `amazonq` and `web` unit tests still failing, to be addressed in follow-up PR **Note that CI is expected to fail for amazonq and web unit tests** --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license. --------- Co-authored-by: Justin M. Keyes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The business logic of auth-related features is complex and implemented separately for all IDEs. Flare/DEXP LSP server has implemented auth that can be reused for all IDEs. The source code was introduced, but not yet instantiated upon activation.
Follow up for #6958
Solution
"amazonqLSP"experiment flagauthProviderthroughIAuthProviderinterface to remove circular dependency withAuthUtilgetChatAuthState()API in favor of newgetAuthState()NOTE: CI is expected to fail, since the reference updates for AuthUtil in the rest of code and unit tests have not been committed yet
feature/xbranches will not be squash-merged at release time.