feat(chat): Adding the grep search tool and file search tool #7083
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Implemented the grep search tool using https://github.com/microsoft/vscode-ripgrep. 2. The grepped result show as clickable file path. 3. Implemented the file search tool. 3. The tool currently is disable in current pr, once grepSearch tool tested, will update the tool_index.json to enable this tool.
|
jguoamz
reviewed
Apr 17, 2025
| NODE_OPTIONS: '--max-old-space-size=8192' | ||
| AWS_TOOLKIT_TEST_CACHE_DIR: '/tmp/.vscode-test/' | ||
| AWS_TOOLKIT_TEST_USER_DIR: '/tmp/.vscode-test/user-data/' | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} |
Contributor
Author
There was a problem hiding this comment.
we are setting this up to increase GitHub API Limit while download the ripgrep binary.
ref: https://github.com/microsoft/vscode-ripgrep
You can produce an API key, set the GITHUB_TOKEN environment var to it, and vscode-ripgrep will use it when downloading from GitHub. This increases your API limit.
- Without this the most CI test will fail during download ripegrep binary.
| "vscode-nls": "^5.2.0", | ||
| "vscode-nls-dev": "^4.0.4" | ||
| "vscode-nls-dev": "^4.0.4", | ||
| "@vscode/ripgrep": "1.15.11" |
Contributor
There was a problem hiding this comment.
is this the right place to add it?
Contributor
Author
There was a problem hiding this comment.
yes, based on the vscode ripgrep, it asked to add in the dependencies, not dev dependencies: https://github.com/microsoft/vscode-ripgrep.
| private createOutput(content: string): InvokeOutput { | ||
| return { | ||
| output: { | ||
| kind: OutputKind.Text, |
Contributor
There was a problem hiding this comment.
use JSON format seems like a better fit for this tool
| public async invoke(updates?: Writable): Promise<InvokeOutput> { | ||
| try { | ||
| const fileUri = vscode.Uri.file(this.fsPath) | ||
| const allFiles = await readDirectoryRecursively(fileUri, this.maxDepth) |
Contributor
There was a problem hiding this comment.
filter to only keep [F] prefix?
| - export HOME=/home/codebuild-user | ||
| # Set up VSCODE_RIPGREP_TOKEN for GitHub API access | ||
| - export VSCODE_RIPGREP_TOKEN=${GITHUB_READONLY_TOKEN} | ||
| - echo "Setting up VSCODE_RIPGREP_TOKEN for GitHub API access" |
Contributor
Author
There was a problem hiding this comment.
similar as the GITHUB TOKEN env, set it setting this up to increase GitHub API Limit while download the ripgrep binary. otherwise, the ripgrep download failed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Solution
feature/xbranches will not be squash-merged at release time.