Skip to content

Conversation

@Hweinstock
Copy link
Contributor

Problem

During the bug bash, someone encountered the LSP attempting to use an expired bearer token. I am unable to reproduce the issue, but can speculate at the cause.

We refresh the bearer token on the LSP every 1 minute, but if the token expires, and then a request is made before the next refresh it can fail.

Note: this is a temporary solution until we have LSP auth.

Solution

  • double the frequency with which we check the token.
  • We still only send the token if it changed, meaning this won't cause noisy request to LSP.

  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Hweinstock Hweinstock changed the base branch from master to feature/hybridChat April 22, 2025 00:47
@github-actions
Copy link

  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

Copy link
Contributor

@jpinkney-aws jpinkney-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't remember if I understood it right, but I thought I read something that said flare will reject the token if the request fails. If thats the case then maybe thats what happened?

@Hweinstock
Copy link
Contributor Author

Yeah, still unsure what happened in the bug bash since it isn't documented, but this can't hurt. If we can get a detailed report, then I can dig deeper on the Flare side.

@Hweinstock Hweinstock marked this pull request as ready for review April 22, 2025 03:04
@Hweinstock Hweinstock requested a review from a team as a code owner April 22, 2025 03:04
@Hweinstock Hweinstock merged commit 52cc07f into aws:feature/hybridChat Apr 22, 2025
28 of 31 checks passed
@Hweinstock Hweinstock deleted the auth/increasePollingFreq branch April 22, 2025 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants