Skip to content

Conversation

@Hweinstock
Copy link
Contributor

@Hweinstock Hweinstock commented Apr 22, 2025

Problem

With aws/language-servers#1037, the chat client will forward the button click event to the host client (VSC in this case). We are then responsible for making a request to the LSP with this button click.

Solution

  • route the button click to the LSP.
  • log any failed button click actions.

Verification

See aws/language-servers#1037, for a demo of the e2e button hookup working.


  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions
Copy link

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.
  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@Hweinstock Hweinstock marked this pull request as ready for review April 22, 2025 12:49
@Hweinstock Hweinstock requested a review from a team as a code owner April 22, 2025 12:49
@Hweinstock Hweinstock merged commit 1b107ab into aws:feature/hybridChat Apr 22, 2025
19 of 22 checks passed
@Hweinstock Hweinstock deleted the buttonClickEvent branch April 22, 2025 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants