telemetry(amazonq): Add changed IDE diagnostics after user acceptance #7130
Conversation
| }) | ||
|
|
||
| it('insert code when left hand size has non empty character', async () => { | ||
| it('insert code when left hand size has non empty character 2', async () => { |
There was a problem hiding this comment.
this is not a typo. this is to make the test description different than another one.
There was a problem hiding this comment.
the tests names are already different?
insert code when left hand size has non empty character
and
insert code when left hand size has no non empty character
| const diagnosticDiff = getDiagnosticsDifferences( | ||
| session.diagnosticsBeforeAccept, | ||
| getDiagnosticsOfCurrentFile() | ||
| ) |
There was a problem hiding this comment.
Curious if the sleep here could pollute the data. For users who accept and continue to edit, resulting in diagnostics of WIP code.
Service side has the final say, but an alternate could be aborting with onDidChangeTextDocument event.
There was a problem hiding this comment.
This is a requirement from server side. They know this metrics can be noisy because we rely on the 3rd party plugins for reporting these problems.
…#5613) When user accepts suggestion from inline completion or chat, there can be a change in the current open editor's IDE diagnostics, this can be used as a measure for code suggestion quality. Ref aws/aws-toolkit-vscode#7130. This change is part of the server side workspace context. To reduce the risk of large blast radius, this change is only applied for users who are in the experiment of server side project context (both treatment and control), which is the Amzn idc users. Verified backend request id 6faef702-938e-42eb-894a-957d9757186e
4 participants
Problem
When user accepts suggestion from inline completion or chat, there can be a change in the current open editor's IDE diagnostics, this can be used as a measure for code suggestion quality. Ref: aws/aws-toolkit-jetbrains#5613
This change is part of the server side workspace context.
To reduce the risk of large blast radius, this change is only applied for users who are in the experiment of server side project context (both treatment and control), which is the Amzn idc users.
E2E verifying request id:
97a3c4d4-0c78-4329-93ae-379d2ec66646.Solution
feature/xbranches will not be squash-merged at release time.