Skip to content

Conversation

@jpinkney-aws
Copy link
Contributor

@jpinkney-aws jpinkney-aws commented Apr 23, 2025

Problem

race conditions can occur with getConnectionMetadata

Solution

instead send the start url through the token update. When it's done this way you don't need to set getConnectionMetadata


  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions
Copy link

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.
  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@jpinkney-aws jpinkney-aws marked this pull request as ready for review April 23, 2025 20:30
@jpinkney-aws jpinkney-aws requested a review from a team as a code owner April 23, 2025 20:30
@jpinkney-aws jpinkney-aws merged commit c9eb334 into aws:feature/hybridChat Apr 23, 2025
19 of 22 checks passed
opieter-aws pushed a commit to opieter-aws/aws-toolkit-vscode that referenced this pull request Apr 24, 2025
## Problem
race conditions can occur with getConnectionMetadata

## Solution
instead send the start url through the token update. When it's done this
way you don't need to [set
getConnectionMetadata](https://github.com/aws/language-server-runtimes/blob/5ba754af403a6f35cd771f27efb987c1580ae6b5/runtimes/runtimes/auth/auth.ts#L158)


---

- Treat all work as PUBLIC. Private `feature/x` branches will not be
squash-merged at release time.
- Your code changes must meet the guidelines in
[CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines).
- License: I confirm that my contribution is made under the terms of the
Apache 2.0 license.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants