-
Notifications
You must be signed in to change notification settings - Fork 747
feat(lambda): Add checkbox in local invoke webview for debugger #7149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
| await vscode.debug.startDebugging(folder, finalConfig, { | ||
| noDebug: !useDebugger, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
? This is already supported by the existing (inherited from vscode) noDebug field:
aws-toolkit-vscode/packages/core/src/shared/sam/debugger/awsSamDebugger.ts
Lines 179 to 183 in 70ba83f
| // | |
| // Debug properties (when user runs with debugging enabled). | |
| // | |
| /** vscode implicit field, set if user invokes "Run (Start Without Debugging)". */ | |
| noDebug?: boolean |
|
Test failures are unrelated to the changes. |
| showNameInput: boolean | ||
| newTestEventName: string | ||
| resourceData: ResourceData | undefined | ||
| useDebugger: boolean |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this probably isn't needed either, because launchConfig on line 33 should already have noDebug field.
oh but if this is "binding" to the vue, maybe this is needed easier/clearer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it is binding to the vue.

Problem
Solution
Add checkbox in local invoke webview so customers can choose to locally invoke with or without debugger
Note:
No tests added since the functionality is already tested here:
aws-toolkit-vscode/packages/core/src/test/shared/sam/debugger/samDebugConfigProvider.test.ts
Line 111 in a7732b9
feature/xbranches will not be squash-merged at release time.