Skip to content

Conversation

@mbfreder
Copy link
Contributor

@mbfreder mbfreder commented Apr 23, 2025

Problem

Solution

Add checkbox in local invoke webview so customers can choose to locally invoke with or without debugger

Note:

No tests added since the functionality is already tested here:


  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions
Copy link

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.
  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

Comment on lines 367 to 368
await vscode.debug.startDebugging(folder, finalConfig, {
noDebug: !useDebugger,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

? This is already supported by the existing (inherited from vscode) noDebug field:

//
// Debug properties (when user runs with debugging enabled).
//
/** vscode implicit field, set if user invokes "Run (Start Without Debugging)". */
noDebug?: boolean

@justinmk3
Copy link
Contributor

This is already supported when the user invokes a sam launch config via Debug: Start Without Debugging :

image

However, it may still be desired to make that more obvious via this new checkbox.

@mbfreder
Copy link
Contributor Author

Test failures are unrelated to the changes.

@mbfreder mbfreder marked this pull request as ready for review April 29, 2025 17:09
@mbfreder mbfreder requested a review from a team as a code owner April 29, 2025 17:09
@mbfreder mbfreder requested a review from justinmk3 April 29, 2025 17:09
showNameInput: boolean
newTestEventName: string
resourceData: ResourceData | undefined
useDebugger: boolean
Copy link
Contributor

@justinmk3 justinmk3 Apr 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this probably isn't needed either, because launchConfig on line 33 should already have noDebug field.

oh but if this is "binding" to the vue, maybe this is needed easier/clearer.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is binding to the vue.

@justinmk3 justinmk3 merged commit 4f1f8b4 into aws:master Apr 30, 2025
27 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants