Skip to content

Conversation

@dogusata
Copy link
Contributor

Problem

  • UI styles coming from flare and the local instance are conflictin.

Solution

  • Latest production version of mynah-ui has the ability to avoid loading styles. Bumped up mynah-ui version and set loadStyles to false.

  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@dogusata dogusata requested review from a team as code owners April 24, 2025 12:42
@github-actions
Copy link

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.

@dogusata dogusata changed the title chore: mynah-ui update Update mynah version with no style loading option Apr 24, 2025
@dogusata dogusata closed this Apr 24, 2025
@dogusata dogusata reopened this Apr 24, 2025
@dogusata dogusata changed the title Update mynah version with no style loading option feat(amazonq): update mynah version with no style loading option Apr 24, 2025
@dogusata dogusata closed this Apr 24, 2025
@dogusata dogusata reopened this Apr 24, 2025
@github-actions
Copy link

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.
  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@opieter-aws opieter-aws merged commit dc849e7 into aws:feature/hybridChat Apr 24, 2025
31 of 36 checks passed
opieter-aws pushed a commit to opieter-aws/aws-toolkit-vscode that referenced this pull request Apr 24, 2025
…#7154)

## Problem
- UI styles coming from flare and the local instance are conflictin.

## Solution
- Latest production version of mynah-ui has the ability to avoid loading
styles. Bumped up mynah-ui version and set `loadStyles` to `false`.

---

- Treat all work as PUBLIC. Private `feature/x` branches will not be
squash-merged at release time.
- Your code changes must meet the guidelines in
[CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines).
- License: I confirm that my contribution is made under the terms of the
Apache 2.0 license.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants