fix(amazonq): handle response errors from lsp #7161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| const errorResult: ChatResult = { | ||
| ...lastPartialResult, | ||
| body, | ||
| const errorMsg = `Error occurred during chat request: ${e}` |
Contributor
There was a problem hiding this comment.
yeah maybe it does make more sense to just put this on client side, it's really not much extra code and it looks like it makes the error handling contract a lot easier to work with
jpinkney-aws
approved these changes
Apr 25, 2025
jpinkney-aws
pushed a commit
to aws/language-servers
that referenced
this pull request
Apr 25, 2025
## Problem - Some follow up work from #1115. ## Solution - Follow the LSP paradigm to return response error to the client, and handle it there. - This is in combination with client side changes [here](aws/aws-toolkit-vscode#7161). - These together produce the following experience on model api failures.
Contributor
|
Is this related to aws/language-servers#1115 ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Response errors returned by the LSP are returned to chat after prepending a custom error message. We can remove this custom error message and rely on flare for a single implementation of this error message.
Solution
feature/xbranches will not be squash-merged at release time.