Skip to content

Conversation

@jpinkney-aws
Copy link
Contributor

Problem

explain, refactor, fix, optimize right click menus aren't working

Solution

re-enable them through flare's genericCommand message

TODO

  • handle generateUnitTests
  • handle explainIssue
    both of these need flare API changes to send generic prompts from the frontend to the backend

  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jpinkney-aws jpinkney-aws requested review from a team as code owners April 25, 2025 18:10
@github-actions
Copy link

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.
  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

await focusAmazonQPanel.execute(placeholder, 'keybinding')
})

const getCommandTriggerType = (data: any): EditorContextCommandTriggerType => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am assuming this fixes the double registering that was happening before?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah I think what was happening was we were creating the commands here + the commands from commands.ts

})
export function registerCommands() {
/**
* make these no-ops, since theres still callers that need to be deprecated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are these commands still exposed to the user? Should we disable them until they are hooked up?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They're only still enabled because other parts of the extension (like security scan) call them. In a future PR i'm going to fully deprecate them here and implement them in commands.ts but for now this just avoids spamming the logs with command not found

return data === undefined ? 'keybinding' : 'contextMenu'
}

export function registerCommands(controllerPublishers: ChatControllerMessagePublishers) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to verify, these still register properly on non-hybrid chat right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah this is only broken for hybrid chat, everything works fine for the regular main branch

@jpinkney-aws jpinkney-aws merged commit 4ceed6e into aws:feature/hybridChat Apr 25, 2025
18 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants