-
Notifications
You must be signed in to change notification settings - Fork 747
fix(amazonq): handle explain, refactor, fix, optimize, sendToPrompt #7169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(amazonq): handle explain, refactor, fix, optimize, sendToPrompt #7169
Conversation
|
| await focusAmazonQPanel.execute(placeholder, 'keybinding') | ||
| }) | ||
|
|
||
| const getCommandTriggerType = (data: any): EditorContextCommandTriggerType => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am assuming this fixes the double registering that was happening before?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah I think what was happening was we were creating the commands here + the commands from commands.ts
| }) | ||
| export function registerCommands() { | ||
| /** | ||
| * make these no-ops, since theres still callers that need to be deprecated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are these commands still exposed to the user? Should we disable them until they are hooked up?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They're only still enabled because other parts of the extension (like security scan) call them. In a future PR i'm going to fully deprecate them here and implement them in commands.ts but for now this just avoids spamming the logs with command not found
| return data === undefined ? 'keybinding' : 'contextMenu' | ||
| } | ||
|
|
||
| export function registerCommands(controllerPublishers: ChatControllerMessagePublishers) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to verify, these still register properly on non-hybrid chat right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah this is only broken for hybrid chat, everything works fine for the regular main branch
Problem
explain, refactor, fix, optimize right click menus aren't working
Solution
re-enable them through flare's genericCommand message
TODO
both of these need flare API changes to send generic prompts from the frontend to the backend
feature/xbranches will not be squash-merged at release time.