Skip to content

fix(resourcecache): improve logging #7175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2025
Merged

fix(resourcecache): improve logging #7175

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions packages/core/src/shared/utilities/resourceCache.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,24 +68,24 @@ export abstract class CachedResource<V> {
const duration = now() - resource.timestamp
if (duration < this.expirationInMilli) {
logger.debug(
`cache hit, duration(%sms) is less than expiration(%sms), returning cached value %s`,
`cache hit, duration(%sms) is less than expiration(%sms), returning cached value: %s`,
duration,
this.expirationInMilli,
this.key
)
// release the lock
await this.releaseLock(resource, cachedValue)
return resource.result
} else {
logger.debug(
`cache is stale, duration(%sms) is older than expiration(%sms), pulling latest resource %s`,
duration,
this.expirationInMilli,
this.key
)
}

logger.debug(
`cache is stale, duration(%sms) is older than expiration(%sms), pulling latest resource: %s`,
duration,
this.expirationInMilli,
this.key
)
} else {
logger.info(`cache miss, pulling latest resource %s`, this.key)
logger.info(`cache miss, pulling latest resource: %s`, this.key)
}

/**
Expand All @@ -104,8 +104,8 @@ export abstract class CachedResource<V> {
timestamp: now(),
result: latest,
}
logger.info(`doen loading latest resource, updating resource cache: %s`, this.key)
await this.releaseLock(r)
logger.info(`loaded latest resource and updated cache: %s`, this.key)
return latest
} catch (e) {
logger.error(`failed to load latest resource, releasing lock: %s`, this.key)
Expand All @@ -129,7 +129,7 @@ export abstract class CachedResource<V> {

const lock = await waitUntil(async () => {
const lock = await _acquireLock()
logger.debug(`try obtain resource cache read write lock for resource %s`, this.key)
logger.debug(`trying to acquire resource cache lock: %s`, this.key)
if (lock) {
return lock
}
Expand Down
Loading