Skip to content

Conversation

@nkomonen-amazon
Copy link
Contributor

Just remove the 'Cancel' button for now when downloading the language server. We do not want to deal with the edge case of a user cancelling part way and then their Q features don't work since it depends on the language server.

Screenshot 2025-04-28 at 12 18 54 PM

TODO: Figure out a better solution for allowing users to cancel the LS download, but then making it easy to download again if they eventually want it. We will also need to design it so they are aware that cancelling will prevent Q features from working.

This will require an update to the spec.


  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

Just remove the 'Cancel' button for now when downloading the language server.
We do not want to deal with the edge case of a user cancelling part way and then
their Q features don't work since it depends on the language server.

---

TODO: Figure out a better solution for allowing users to cancel the LS download,
but then making it easy to download again if they eventually want it. We will also
need to design it so they are aware that cancelling will prevent Q features from working.

This will require an update to the spec.

Signed-off-by: nkomonen-amazon <[email protected]>
@nkomonen-amazon nkomonen-amazon requested a review from a team as a code owner April 28, 2025 16:21
@github-actions
Copy link

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.
  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@nkomonen-amazon nkomonen-amazon merged commit 2f103ff into aws:feature/hybridChat Apr 28, 2025
18 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants