refactor(amazonq): Change Q LSP downloading message text #7185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They want it to be slightly different, but the base lsp installer class has a generic message. SOLUTION: Allow an override message to be given from a specific LspResolver implementation. This override message will show when the download is happening. Everyone is happy. Signed-off-by: nkomonen-amazon <[email protected]>
|
jpinkney-aws
approved these changes
Apr 28, 2025
Contributor
jpinkney-aws
left a comment
jpinkney-aws
left a comment
There was a problem hiding this comment.
Makes sense, we can probably get rid of this when we deprecate the workspace context language server
Hweinstock
approved these changes
Apr 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PROBLEM:
When installing the LSP for Q we get a message that says
"Installing 'Amazon Q' language server", but they want it to be slightly different ("Updating Amazon Q plugin"). The issue is the base class for the lsp installer class has a generic message that is not easy to customize.SOLUTION:
Allow an override downloading message to be defined in each specific LspInstaller implementation. This message is then routed in to the LspResolver (the thing that downloads the Lsp), and the message is displayed here. This override message will show when the download is happening. Everyone is happy.
feature/xbranches will not be squash-merged at release time.